algorithm-cote-study/baekjoon-algorithm

๐Ÿ“ข Code merge ๊ด€๋ จ ๊ฑด

cyeji opened this issue ยท 1 comments

cyeji commented

ํ”„๋กœ์ ํŠธ PR Merge ๊ด€๋ จ ๊ฑด ์ˆ˜์ •์‚ฌํ•ญ ์—…๋ฐ์ดํŠธ ํ–ˆ์Šต๋‹ˆ๋‹ค.

Before
์ผ๊ด„ merge

Now
Reviewer ์‹ ์ฒญ์ž๊ฐ€ ๋ชจ๋‘ ์Šน์ธ์„ ํ–ˆ์„์‹œ์—๋งŒ merge๊ฐ€๋Šฅ

cyeji commented

PR ํ›„ Reviewer ๋“ฑ๋ก ๋ฐฉ๋ฒ•

  • Create Pull Request ํ™”๋ฉด ์˜ค๋ฅธ์ชฝ Reviewers ์„ค์ • ๋ฐ Assignees ์„ค์ • (๋‘๋ช… ์ „๋ถ€ ์„ ํƒํ•  ๊ฒƒ)

แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2023-05-07 แ„‹แ…ฉแ„’แ…ฎ 2 40 50

  • ์„ ํƒ ์™„๋ฃŒ ์‹œ ํ‘œ๊ธฐ๋˜๋Š” ํ™”๋ฉด

แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2023-05-07 แ„‹แ…ฉแ„’แ…ฎ 2 39 58

Reviewํ›„ ์ƒํƒœ ๋ณ€๊ฒฝ

  • ReviewChanges ๋ฒ„ํŠผ ํด๋ฆญ ํ›„, ์ƒํƒœ๋ณ€๊ฒฝ (comment, approve, request changes)
  1. comment (์ฝ”๋ฉ˜ํŠธ๋งŒ ๋‹ฌ๊ณ  ๋จธ์ง€ ๋˜๋„๋ก)
  2. approve (์Šน์ธ)
  3. requestChanges (ํ”ผ๋“œ๋ฐฑ ๋ฐ›๊ณ  ์ˆ˜์ •ํ•˜๊ธฐ ์ „๊นŒ์ง€ merge ๊ธˆ์ง€)
    ์ƒํƒœ๋ณ€๊ฒฝ ์„ค์ •์€ ์œ ๋™์ ์œผ๋กœ ์„ค์ •ํ•ฉ๋‹ˆ๋‹ค.

ex. ํฌ๊ฒŒ ๋ฌธ์ œ๋Š” ๋˜์ง€ ์•Š์ง€๋งŒ ๊ณ ์น˜๋ฉด ์ข‹์Œ Comment, ์ฝ”๋“œ ๋ณ€๊ฒฝ ์š”์ฒญ ํ•„์š” ์—†๋Š” ์ƒํƒœ Approve, ์ฝ”๋“œ์—์„œ ๋ณ€๊ฒฝ๋˜์ง€ ์•Š์œผ๋ฉด ๋ฌธ์ œ๊ฐ€ ์žˆ์„ ๋•Œ requestChanges

แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2023-05-07 แ„‹แ…ฉแ„’แ…ฎ 2 45 15