alibaba/nginx-http-concat

Return delimiter when file was not found

simong opened this issue · 4 comments

Hi, we want to use the http-concat module to batch get multiple files (not only css/javascript) and we're currently using a custom concat_delimiter to be able to split on that and get the body for each file individually.

However, when requesting a file that doesn't exist (we're using concat_ignore_file_error on) the file gets ignored but no delimiter gets added. At that point our UI has no idea which file wasn't found.
Would it be feasable to add an empty body (even better: have something configurable like concat_not_found_body) and the delimiter? That way, if you request 4 files, you always get 3 delimiters. (and thus 4 separate bodies)

Another good addition would be if you could configure the module in such a way that the filename is used in the delimiter. (That would also deal with our problem)

Thanks for your report. Your request is reasonable. We'll consider it in the next release.

I have an idea. Can you added the filename as comment at the beginning of the your asset?

Thanks!
Unfortunately we can't add the filename.

I like this feature if it is an optional one.

the typical 404 error will make me quick to realize there is a problem.