Remove trailing whitespace (flagged by popular linters)

Question

Remove trailing whitespace (flagged by popular linters)

klieret opened this issue 2 years ago · 11 comments

I am using the trailing-whitespace pre-commit hook. It's one of the default hooks and hence is very popular¹.

However, the all-contributors is currently inserting trailing whitespace in the contributor table. This means that pre-commit will fail for every PR that all-contributors is opening.

While the hook can fix this automatically with an additional commit, this behavior is still not exactly desired.

You can see the whitespace here.

A quick search with sourcegraph tells me there's more than 2k repositories use this hook. ↩

Answer 1 · 2022-10-05T23:04:16.000Z

Same issue here, but with a different linter. It looks like it now wraps the entire table into another tag <tbody> for unknown reason. The whitespace stems from a <tfoot> tag which is empty, useless, and gets added after the body.

It would be great if these changes could be reverted—or did the old layout not work well?

My huge diff is here now: https://github.com/grammyjs/grammY/pull/286/files

Answer 2 · 2022-10-06T14:22:39.000Z

🎉 This issue has been resolved in version 6.23.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Answer 3 · 2022-10-06T14:23:46.000Z

@klieret @KnorpelSenf Thanks for reporting. This should be fixed now when using the latest version of CLI. However, if you are using the bot, it is having some issues in deployment right now. We are currently investigating the cause. We will update you. Thanks!