allegro/turnilo

expose limit to be configurable from UI / command line

lukass77 opened this issue · 5 comments

lukass77 commented

saw that on 1.39.0 the default limit is 100 for sort by
can we configure the default limit to be smaller .. so on the first query hit ..
query will not process 100 entries by default ..
default will be 100 , but in case limit value is provided it will overwrite the default value with the provided value

I asume smaller limit can improve performance ..in case user need smaller limit

adrianmroz-allegro commented

Please note few things:

  1. The '100' is not a hardcoded value. Default limit for Splits is chosen based on Dimension available limits.
  2. Dimension limits are already customisable - each dimension can have different limits.
  3. Visualisations can affect limits so it is not set in stone.

It would be impossible to create one setting for this. And I'm afraid it will be very hard to understand what it really does. I much prefer to avoid unnecessary configurations - they have very high maintenance cost.

lukass77 commented
adrianmroz commented

It's just property limits in dimension configuration.

I see it's not in the documentation. I'll add it tomorrow!

lukass77 commented

Hey any update on this , documentation change ?

adrianmroz-allegro commented

Documentation added in #1058