allenai/scibert

BertTextClassifier __init__ guaranteed to raise NotImplementedError

swfarnsworth opened this issue · 0 comments

self.classifier_feedforward = torch.nn.Linear(self.text_field_embedder.get_output_dim() , self.num_classes)

BertTextClassifier requires an instance of TextFieldEmbedder and calls get_output_dim on that instance, however that method always raises NotImplementedError. Is this meant to deliberately un-implement a method from the superclass, or is it intended that that functionality will be implemented at a future time?