allenporter/flux-local

No diff when comparing two versions of helm charts

tropnikovvl opened this issue · 4 comments

tropnikovvl commented

I use this workflow

      - name: Setup Flux CLI
        uses: fluxcd/flux2/action@main

      - uses: allenporter/flux-local/action/diff@5.0.1
        id: diff
        with:
          live-branch: develop
          path: clusters/${{ matrix.cluster_path }}
          resource: helmrelease
          debug: true

      - name: PR Comments
        uses: mshick/add-pr-comment@v2
        if: ${{ steps.diff.outputs.diff != '' }}
        with:
          message-id: ${{ github.ref }}/flux-diff
          message-failure: Unable to post HelmRelease diff
          message: |
            `````diff
            ${{ steps.diff.outputs.diff }}
            `````

But for some reason I get the diff on some helm releases and not on others.
I couldn't find a direct relationship.
As an example, I can give the helm release for kube-prometheus-stack.

When updating from version 58.2.1 to version 58.2.2, the diff is not generated for me, although according to the logs it should be and in the changes itself I also see what is changing.

Screenshot 2024-04-26 at 17 52 36

allenporter commented

Can you give me some additional details about how the repo is setup? Ideally a link to a github pr for this happening would help, though if you have a private cluster then updating the demo repo to reproduce this would help.

allenporter commented

What are the differences you expect?

Keep in mind the default diff will strip these attributes and labels by default:

--strip-attrs "helm.sh/chart,checksum/config,app.kubernetes.io/version,chart"
tropnikovvl commented

I guess I didn't pay attention to that, thanks for the help!