allenwq/devise-multi_email

README is wrong about send_devise_notification method placement

letiesperon opened this issue · 1 comments

The following part of the README:

The [Devise README](https://github.com/plataformatec/devise#activejob-integration) describes how to use ActiveJob to deliver emails in the background. Normally you would place the following code in your `User` model, however when using _devise-multi_email_ you should place this in the `Email` model.

does not seem to be correct. If I put the method send_devise_notification on the Email model, the debugger does not hit it. If I place it on the User model, the debugger stops. Should we drop this part of the README?

Thanks @letiesperon , you comment might be valid, it has been some time and I am no long working on Rails related projects.

Could you help with more investigation? does the email get send to the primary one in active job?