Python 3.7 requirement
Closed this issue · 6 comments
Hi
First of all thank you for making this tool available for everyone.
I was wondering if there is any reason for the Python 3.7 requirement? I cloned the code and ran it on Python 3.6 without experiencing any issues so far.
Unfortunately, the Python 3.7 requirement doesn't allow me to install your package via pip in a 3.6 environment. Would it be possible to change the requirements?
Thanks a lot.
Do all the tests pass on Python 3.6? If I remember well, we had issues on 3.6.
If you confirm the tests are passing, I will release a fix.
I'm not very familiar with tests but I think all of them are passed.
I got the output below when executing python -m unittest discover . -v in the text2num directory. My python version is Python 3.6.9 :: Anaconda, Inc.
test_alpha2digit_decimals (tests.test_text_to_num_en.TestTextToNumEN) ... ok
test_alpha2digit_formal (tests.test_text_to_num_en.TestTextToNumEN) ... ok
test_alpha2digit_integers (tests.test_text_to_num_en.TestTextToNumEN) ... ok
test_alpha2digit_ordinals (tests.test_text_to_num_en.TestTextToNumEN) ... ok
test_alpha2digit_signed (tests.test_text_to_num_en.TestTextToNumEN) ... ok
test_alpha2digit_zero (tests.test_text_to_num_en.TestTextToNumEN) ... ok
test_and (tests.test_text_to_num_en.TestTextToNumEN) ... ok
test_relaxed (tests.test_text_to_num_en.TestTextToNumEN) ... ok
test_text2num (tests.test_text_to_num_en.TestTextToNumEN) ... ok
test_text2num_centuries (tests.test_text_to_num_en.TestTextToNumEN) ... ok
test_text2num_exc (tests.test_text_to_num_en.TestTextToNumEN) ... ok
test_text2num_zeroes (tests.test_text_to_num_en.TestTextToNumEN) ... ok
test_alpha2digit_decimals (tests.test_text_to_num_fr.TestTextToNumFR) ... ok
test_alpha2digit_formal (tests.test_text_to_num_fr.TestTextToNumFR) ... ok
test_alpha2digit_integers (tests.test_text_to_num_fr.TestTextToNumFR) ... ok
test_alpha2digit_ordinals (tests.test_text_to_num_fr.TestTextToNumFR) ... ok
test_alpha2digit_signed (tests.test_text_to_num_fr.TestTextToNumFR) ... ok
test_alpha2digit_zero (tests.test_text_to_num_fr.TestTextToNumFR) ... ok
test_article (tests.test_text_to_num_fr.TestTextToNumFR) ... ok
test_relaxed (tests.test_text_to_num_fr.TestTextToNumFR) ... ok
test_text2num (tests.test_text_to_num_fr.TestTextToNumFR) ... ok
test_text2num_centuries (tests.test_text_to_num_fr.TestTextToNumFR) ... ok
test_text2num_exc (tests.test_text_to_num_fr.TestTextToNumFR) ... ok
test_text2num_variants (tests.test_text_to_num_fr.TestTextToNumFR) ... ok
test_text2num_zeroes (tests.test_text_to_num_fr.TestTextToNumFR) ... ok
test_trente_et_onze (tests.test_text_to_num_fr.TestTextToNumFR) ... ok
----------------------------------------------------------------------
Ran 26 tests in 0.020s
OK
OK, we've been a bit too conservative 😁
I'll make a new release.
Just realizing that our Continuous Integration is set with 3.6 too 😃
We'll thank you for noticing, I don't know what happened.
version 2.0.1 released!
Great, thank you very much! 😃