rc6 new UI cannot fully see all tags in detailed view
PudiccaA opened this issue · 7 comments
Describe the bug
Upon upgrading to the latest rc6 version, after I double clicked the image entering the detailed panel, there was only one row showing some of the tags I assigned to the image. Although I could scroll down to see the other rows, some of the tags were still blocked.
I have attached a few screenshots to illustrate this problem:
As shown above, I have 8 tags attached to this image, yet 3 of them were completely blocked, no matter how I played with the scroll bar.
Personally, I would prefer the big div block which showed most of the tags without scrolling in the previous version.
To Reproduce
Steps to reproduce the behavior:
- Assign multiple tags to an image.
- Double click the image to enter the detail panel.
- Check the tags on the right.
- Scroll down.
- See the problem.
Expected behavior
- A div block that shows all tags without scrolling.
- Scrolling without blocking tags.
Allusion version
- e.g. v1.0.0-rc6
Desktop OS
- e.g. Windows 10
Additional context
I see in the other issue that I can adjust the style myself in dev-tools, but it is also mentioned that this change would be lost after restarting Allusion.
After disabling the "max-height" property, I can increase the tag div height to display all tags assigned without scrolling now.
However, the modification won't be preserved if I close the detail panel and then reopen it.
And this tweak would also affect the tag selector at the top when going back to the overview window.
The tag selector at the top and the tag selector in the detail panel probably should have separate class names.
Thanks for reporting! Yeah, that's unintentional, will fix it like that probably
After looking into the codes, I think the problem is that both the Searchbar container and the Inspector container (which uses FileTags component) utilize the same TagSelector component.
Thanks for developing this great software, I have tagged more than 25,000 reference images I collected, and have recommended this software to artists I know.
For now I'm playing around the codes in a local build so I can continue tagging with a temporary fix while waiting for updates. Thanks again!
My current temp fix. Top SearchBar not affected.
Same problem was found in the tag editor within overview panel as well.
Removing/Adjusting "max-height" restriction within "div:last-child" selector in tag-editor.scss would allow tags to be displayed completely.
I have also made some tweaks to make the whole area below tags clickable, instead of only one line.
Before:
After:
