Firefox extension omits `:` after `http(s)`
Closed this issue · 6 comments
Steps to reproduce
- Install BT extension for Firefox
- Click the extension button on some website
- Open link from BT in any browser
Expected behavior
The new browser opens the original link.
Actual behavior
The new browser opens the original link without :
after https
, resulting in connection error page, for example: https//github.com
Notes
Since there were no recent releases of BT or the extension, I suspect this could be caused by very recent update of Firefox to v122. Extension in Edge seems unaffected.
Versions:
- Windows 11 Enterprise, Version 22H2, OS build 22621.3007
- Firefox 122.0 (64-bit)
- Extension: 1.2.1
- BT 3.6.2
Hmm, I'm thinking whether there was a change in URL handling mechanism:
bt/browser-extensions/firefox/background.js
Lines 18 to 20 in 4572ed2
The URL added after x-bt://
isn't encoded, so it's possible Firefox trims the :
character in order to perhaps prevent some security issue?
Thanks, I can reproduce this on my Firefox, and it used to work (nothing changed since then) so it's definitely something in the Firefox itself. Will keep digging and come up with a fix.
I can confirm Firefox it removing :
- the URL arrives to BT without it. 3.7.2 will fix this issue.
Please try installing 3.7.2. Firefox extension does not need an update.
Thank you Ivan! I'm off for a week, but will try it first thing once I'm back.
@aloneguid The fix works for me in BT v3.7.3. Thank you Ivan!