Infinite while loop
Opened this issue · 2 comments
DanOKeefe commented
If the condition in this while loop ever evaluates to True
, it will always be True
.
current_dt and market_open never change wthin the while loop, which means that since_market_open will never change within the while loop. This means
since_market_open.seconds // 60 <= 14
will never evaluate to False
if it is intially True
Momentum-Trading-Example/algo.py
Lines 392 to 394 in be43528
I believe it should be:
while since_market_open.seconds // 60 <= 14:
time.sleep(1)
current_dt = datetime.today().astimezone(nyc)
since_market_open = current_dt - market_open
nickvertucci commented
Hey Dan,
Found these changes although the code has been updated since.
Were you able to get it working? Mine seems to be just stuck on watching symbols...
solaress1980 commented
I think so too @DanOKeefe. I also think it should wait until market opens to check this 15 minutes elapsed logic so that the program does not run before 9am.