alphagov/govuk-prototype-kit-common-templates

For consistency, change all components from html to nunjucks

Closed this issue · 5 comments

We made a decision a while back to tell people to use Nunjucks for components. It would make sense and be less confusing to change all components in the templates from html to nunjucks

This PR already starts the transition to Nunjucks, but is specific to one template:

I've done this as part of the work in progress for supporting .njk - all our files will be updated to .njk as part of that PR (in its current form)

@nataliecarey this is to convert the html code of the components in the templates to use nunjucks macros instead - isn't that separate from the .njk extension work?

Sorry, I forgot they'd been moved out to their own project :)

Yes, I think we should make this change - to be clear we're talking about templates rather than components right? Templates can be renamed any time, components would have to wait until we've finished that work.

no worries, it's gov.uk components within templates so stuff like back link and buttons - no renaming at all. See the Check answers PR above for an example - it switches to the summary list macro from html.

@nataliecarey to review whether this needs to happen after njk change