Test across our supported browsers

Question

Test across our supported browsers

Closed this issue 6 years ago · 5 comments

We should run our tests in the different environments that we support https://www.gov.uk/service-manual/technology/designing-for-different-browsers-and-devices

This should not replace manual testing where appropriate but will catch simple issues like #323 and more complex issues in the future (if we used a ES5 feature without polyfilling for example)

I was thinking we could use sauce labs' free open source tier.

I'm looking into this but raising encase I don't have the time. 👍

Answer 1 · 2016-09-06T15:22:14.000Z

@NickColley thanks for raising this. Can you give more detail on the ES5 feature issue so when we come to tackle this we know the full history of the issue?

Answer 2 · 2016-09-06T15:24:51.000Z

@tombye just an example, I've stopped commits from being merged because they're using ES5 without the author realising it but we could easily miss that.

Answer 3 · 2016-09-06T15:54:40.000Z

@NickColley anything you can link to? Might help future story writing to have examples to point to.

Answer 4 · 2016-09-07T13:49:54.000Z

(Shared an example with @tombye privately since the purpose of this issue is not to make anyone feel like it's their fault but rather that anyone contributing could make this easy mistake)

Answer 5 · 2018-08-30T09:30:01.000Z

Following the launch of the GOV.UK Design System, GOV.UK Frontend Toolkit will now only get major bug fixes and security patches, so I'm going to close this.