Should provided variables have `!default` flag?
Closed this issue · 3 comments
esr360 commented
You'll have to forgive my lack of confidence with this issue, but should variables within the toolkit (e.g. https://github.com/alphagov/govuk_frontend_toolkit/blob/master/stylesheets/_grid_layout.scss#L6) have the !default flag?
If I'm including the toolkit as a git submodule, I don't want to be touching any of the source files, but I may want to override some of the values.
If so, I am happy to go through everything and create a pull request.
hbweb commented
@esr360 - this is exactly what I'm after atm. I want to override this default container's width but don't want to mess up with the source file. Any suggestion ? tks
robinwhittleton commented
@esr360 why don’t you go ahead with a PR. Can review next week.