selection-buttons.js doesn't respect the disabled="disabled" attribute
Closed this issue · 5 comments
If a radio button or checkbox has the disabled="disabled" attribute, selection-buttons.js still allows the user to tick/select and untick/unselect.
Attached is
selection-buttons.js.patch.txt
a patch for a simple fix. I'm not sure if this is the best way to do it, but at least it's something that works.
Hi Khaled, I’ve been working on a revised version of the checkboxes / radios that respect the disabled attribute and don’t need for selection-buttons.js (at a cost of reworking the markup). We’re currently fighting some Travis problems but once we fix those we’ll release a new version of GOV.UK Elements (probably 3.0.1) that’ll include those.
We’ve updated Elements to no longer need selection-buttons.js for radios and checkboxes, and marked the JS as deprecated. There’s also styling in elements to respect disabled. Does this answer your need?
HI, @khaledzaidan
as this file has been deprecated in favour of new radios and checkboxes (see above response) Would you object to me closing this issue?