alphagov/gsp

github resource incorrectly skips empty commits by developers

Closed this issue · 1 comments

What should happen

github-resource should only skip empty commits signed by the github flow gpg key

What currently happens

github resources skips ALL empty commits if signed by anyone and reports “skipping empty github signed commit”

Why is the impact..

  • The message "skipping github signed commit" is a lie and may confuse someone
  • Sometimes you have to do an empty signed commit to authenticate a previously unauthenticated commit ... currently you have to go looking for typos to fix

Context

The github resources loads ALL the keys before performing the check for empty commits... it should probably only load the flow-key initially and load the rest after the "empty commit" check

Given that "skipping GitHub signed commit" is no longer a thing in the code and hence we no longer have to manually import GPG keys and check signatures, this issue is no longer relevant.

There's lots more context on the changes we made and why we made them in #197 (comment) or the Trello card itself.