raw.scss isn't being used so should be refactored out...
Closed this issue · 6 comments
Previously, appending a query parameter of ?raw would apply a class of raw to the body element. This would use the styles in raw.scss.
I can't find when this got dropped, but we should remove the styles if they're no longer being used.
I noticed this the other day – wasn't sure if it was intentional.
This means our PNG output is only the graph, not the impact number, which
may or may not be appropriate.
I feel like we need to have a proper discussion around embedding etc.
Apparently we've agreed to do embedding for gov.uk/transformation – perhaps
we can do it when we're working on this.
H
We can screenshot an arbitrary amount of the modules 'page per thing' page
using the selector query parameter, so we should be fine
On 7 July 2014 10:35, Henry Hadlow notifications@github.com wrote:
I noticed this the other day – wasn't sure if it was intentional.
This means our PNG output is only the graph, not the impact number, which
may or may not be appropriate.I feel like we need to have a proper discussion around embedding etc.
Apparently we've agreed to do embedding for gov.uk/transformation –
perhaps
we can do it when we're working on this.H
—
Reply to this email directly or view it on GitHub
#629 (comment).
Can we close this then?
Go for it
On 31 July 2014 11:31, Ben Marvell notifications@github.com wrote:
Can we close this then?
—
Reply to this email directly or view it on GitHub
#629 (comment).
Shouldn't we remove the code that isn't being used?
Good point. Reopening.