alpmestan/ghc.nix

valgrind

Closed this issue · 1 comments

I got the news that running nofib under cachegrind delivers precise results (albeit slowly). That necessitates the presence of valgrind, so I added:

modified   default.nix
@@ -20,6 +20,7 @@ in
 , withHadrianDeps ? false
 , withDwarf ? nixpkgs.stdenv.isLinux  # enable libdw unwinding support
 , withNuma  ? nixpkgs.stdenv.isLinux
+, withGrind ? true
 , cores     ? 4
 }:
 
@@ -57,6 +58,7 @@ let
       ]
       ++ docsPackages
       ++ optional withLlvm llvm_7
+      ++ optional withGrind valgrind
       ++ optional withNuma numactl
       ++ optional withDwarf elfutils
       ++ optional withIde ghcide

It works. Okay to submit as PR?

@ggreif Absolutely, the patch looks mergeable as-is. :-)