alshdavid/BorrowScript

Dark mode

Closed this issue ยท 5 comments

Likely the very least of this project's priorities, but worth mentioning the SVGs aren't visually great on dark theme.

Screenshot from 2021-11-12 13-46-26

Oh yikes, and there is no way to create adaptive markdown files in GitHub ๐Ÿ˜“

No, but there is a way to style within SVG and use prefers-color-schema

svg { fill: #000; }
@media (prefers-color-scheme: dark) {
  svg { fill: #fff; }
}

or something similar

Unfortunate Github inject images as <img /> tag, dynamic styles won't work

Luckily the intro images are all SVGs so I was able to use the <style> approach within the svgs.

Unfortunately it will only respect the system theme - so if you have a light system but override GitHub to use dark mode, it will continue to use the light theme svgs.

image
image

@alshdavid thanks, it works like a charm (GNOME on ArchLinux in Dark Mode) ๐Ÿ‘