Please build for Scala 2.12.0

Question

Please build for Scala 2.12.0

Closed this issue 5 years ago · 6 comments

Answer 1 · 2016-11-07T14:16:19.000Z

@romix I have tried to make a PR to help but I ran into some small issues, I'm no Scala developer so it is more difficult for me to fix them:

-optimise option has been rewritten for Scala 2.12.0
1 test is failing.
some deprecations.

Also in a console do an sbt clean compile and see the warnings.

You can use my commit as start point if you wish:
guidomedina@f0a83fa

Answer 2 · 2016-11-10T14:30:21.000Z

If you change the failing test like this

  it should "roundtrip immutable LongMap" in {
     ...
    kryo.register(classOf[scala.collection.immutable.LongMap[_]], 3042) // instead of LongMap[Any]

it passes, but I have no Idea why

Answer 3 · 2016-11-10T14:37:17.000Z

Thanks @TrustNoOne
That's one down, we only need @romix to jump in and figure out the other small issues, I'm sure for a Scala developer these small issues are easy to fix.

Answer 4 · 2016-11-10T14:42:58.000Z

umh, it looks like it's failing again but I don't understand why, It passed once when I ran it in intelliJ O_o

Answer 5 · 2016-11-10T17:37:02.000Z

I will send a PR soon, I have it working but want to clean it up.

Answer 6 · 2019-09-25T07:11:53.000Z

v0.5.1 is build against Akka-2.4 and Kryo-4.0 and is available for Scala-2.11 and Scala-2.12