[BUG] Pause State broken in Pong Demo

Question

[BUG] Pause State broken in Pong Demo

PhilippvK opened this issue 4 years ago · 7 comments

PhilippvK commented 4 years ago

Describe the bug
2 Bugs:

Pause is canceled immediately as keys are not debounced
Top and Bottom Walls are flickering in Paused mode as only one buffer contains walls.

To Reproduce
Press P

Expected behavior
Steady Switches between Game and Paused mode

Screenshots
/

Desktop (please complete the following information):
Irrelevant

Additional context
In #48 if "fixed" the first (debounding) problem by adding a vTaskDelay(100) statement, but the problem will still be there if the key is held too long

Answer 1 · 2020-05-08T15:10:51.000Z

I will look into this soon as well as updating the branch to use the new refactored code

Answer 2 · 2020-05-08T15:13:43.000Z

I also think that 1 is completely ok and doesn't really need addressing. Just those walls.

Answer 3 · 2020-05-08T16:00:04.000Z

I also think that 1 is completely ok and doesn't really need addressing. Just those walls.

But it gets worse if you comment out my vTaskDelay workaround...

Answer 4 · 2020-05-08T16:01:21.000Z

I will look into this soon as well as updating the branch to use the new refactored code

Are you going to move all drawing statements to the PongControlTask?

I think this would solve the flickering as the double framebuffer is not a problem when it is cleared every frame.

Answer 5 · 2020-05-08T16:06:42.000Z

yer I can do that

Answer 6 · 2020-05-12T09:43:19.000Z

Took the easy path and just blanked the screen during pause (except text). Seems like pressing pause a few times can freeze up the game. Will have to look into that first before this is closed.

Answer 7 · 2020-05-12T13:20:49.000Z

All fixed up, also added randomness to ball starting angles (velocities)