amacneil/spree-refinery-authentication

Make it work with Spree version 1.3x

astiam opened this issue · 6 comments

Currently it is not possible to use this gem with Spree 1.3x.

I'm not really sure if a gem like this is necessary if using Spree 1.3x, but if it is the case then it should have no reference to a specific version of Spree in the gemspec, so newer versions can be compatible.

Thanks

Hmm.. Have you tried just changing the dependencies in the gemfile to see if it works? I don't have an install of spree/refinery to test on right now.

You mean changing the Spree version? Yes, if I downgrade it to 1.2x it works just fine, but I actually need version 1.3x, which is not compatible with the gem. On the other hand, I cannot force the version of Spree the gem requires.

I guess that if the gemspec file of this gem simply had gem 'spree' it would make it compatible.

Yeah that's what I meant. If you fork this gem and edit the gemfile to gem 'spree', does it work? If so I can make that change, but it's probably not a good idea unless it actually works.

Yes, it works that way. It is installed with no problem.

Ok great. I just updated the gemspec, so you should be able to use my master branch now with no problems.

Thanks a lot!