amaelftah/laravel-trix

IE 11 not supported

dvlpr91 opened this issue · 6 comments

dvlpr91 commented

error occured

...
for (var tag of laravelTrixInstanceStyles) {
...

what the for ... of

dvlpr91 commented

te7a-houdini/laravel-trix/resources/views/trixassets.blade.php

for (var tag of laravelTrixInstanceStyles) {
to
for (var tag in laravelTrixInstanceStyles) {

  • 👍1
amaelftah commented

fixed in v2

  • 👍1
dvlpr91 commented

Hey!!!!!!!!

fixed in v2.0.0.

But, it came back again in v2.0.1.

why?

amaelftah commented

@dvlpr91 it caused this issue #26

dvlpr91 commented

Did you change only "of" to "in"?

I am not good at English, so please understand that I am using a translator.

I write the code for normal operation below as much as possible.

FROM

...
for (var tag of laravelTrixInstanceStyles) {
  style.innerHTML += tag.textContent + ' ';
}
...

TO

...
for (var i = 0; i < laravelTrixInstanceStyles.length; i++) {
  style.innerHTML += laravelTrixInstanceStyles[i].textContent + ' ';
}
...

OR

for (var i in laravelTrixInstanceStyles) {
  if (i < laravelTrixInstanceStyles.length) {
      style.innerHTML += laravelTrixInstanceStyles[i].textContent + ' ';
  }
}

I didn't check, but I simply wrote the code, thinking about the difference between "in" and "of" in javascript.

Try it.

  • 🚀1
amaelftah commented

@dvlpr91 no problems . ok i got it now . i will reopen the issue and we can convert to normal for loop

  • 👍1