amanjha8100/chords

Update project's structure

JuaniBattiston opened this issue · 8 comments

JuaniBattiston commented

Enhancement/Feature

Project files are a bit messy rn. I'd suggest creating a cog folder and dynamically loading the cogs to add scalability to the project.

I can work on this if approved

amanjha8100 commented

Hey @Batucho , I did realise this and therefore there is a similar issue already present #35 . Currently every command is in music.py and it needs to be modulated asap. But currently I am waiting on certain issues to get completed and then move on to modulation. I would like you to wait a couple more days and then we will move on with this part.

JuaniBattiston commented

Seems like a good idea. Mention me when you think it should be done.

  • 👍2
amanjha8100 commented

@Batucho if you are willing to work on this issue, we can start, but let's have a small discussion on how to proceed with this here!

JuaniBattiston commented

I'll work on it no problem. What is it that you want to discuss? My idea is to move commands into a cog folder and load them in a dynamic way. Other helper files could be moved into a utils folder?

amanjha8100 commented

If there are huge changes please consider submitting PRs with small changes so that the pipeline stays intact with no problems at all. Apart from this your idea sounds great!

JuaniBattiston commented

There shouln't be any big/breaking changes. I might push some code formatting if I may, do you want me to do this in a different pr? Feel free to assign me this issue.

JuaniBattiston commented

Hey! @amanjha8100 I would like to split the pr in 2 if that's fine by you. The first one will be for formatting the code, fixing minor typos and minor changes, and the second one will be the big one. Otherwise it will be to big. What do you think?

amanjha8100 commented

I am in support of breaking the contribution in as many PR as possible. As we are changing the structure of the project more PRs means less likely prone to errors.