amansrivastava17/embedding-as-service

Performance issue in /server/embedding_as_service (by P3)

Opened this issue · 2 comments

DLPerf commented

Hello! I've found a performance issue in /text/xlnet/models/data_utils.py: dataset.batch(bsz_per_core, drop_remainder=True)(line 571) should be called before dataset.cache().map(parser).repeat()(line 570), which could make your program more efficient.

Here is the tensorflow document to support it.

Besides, you need to check the function parser called in .map(parser) whether to be affected or not to make the changed code work properly. For example, if parser needs data with shape (x, y, z) as its input before fix, it would require data with shape (batch_size, x, y, z) after fix.

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

DLPerf commented

Hello, I'm looking forward to your reply~

ashutoshsingh0223 commented

Hi

Sorry for the delayed response.
Please feel free to create a PR. We will review it.

Thanks