Providing name as an option seems odd for `NewCollection`
tazarov opened this issue · 0 comments
tazarov commented
newCollection, err := client.NewCollection(
context.TODO(),
collection.WithName("test-collection"),
collection.WithMetadata("key1", "value1"),
collection.WithEmbeddingFunction(openaiEf),
collection.WithHNSWDistanceFunction(types.L2),
)
The Metadata, EF, DF are ok to be options, but name is absolutely necessary. We do validate that it is present, but the method with the option seems counter-intuitive for mandatory param