amitds1997/remote-nvim.nvim

Setup fails if remote is using fish shell

Opened this issue · 2 comments

jariz commented

Describe the bug

If I connect to a remote where I have the default shell set to the fish shell, it will fail at the Setting up Neovim on remote host step.
If I chsh to bash, everything works fine.

To reproduce

Steps to reproduce the behavior:

# on remote
apt install fish 
fish
chsh -s (which fish) youruser

Connect to the machine with RemoteStart, it will immediately fail.
Error log:

ERROR wo 28 aug 21:19:21 2024 /Users/jari/.local/share/nvim/lazy/remote-nvim.nvim/lua/remote-nvim/providers/provider.lua:760: 'Setting up Neovim on remote host' failed
stack traceback:
	.../remote-nvim.nvim/lua/remote-nvim/providers/provider.lua:760: in function <.../remote-nvim.nvim/lua/remote-nvim/providers/provider.lua:759>
	[C]: in function 'find'
	...azy/remote-nvim.nvim/lua/remote-nvim/providers/utils.lua:181: in function <...azy/remote-nvim.nvim/lua/remote-nvim/providers/utils.lua:180>
	vim/shared.lua: in function 'tbl_filter'
	...azy/remote-nvim.nvim/lua/remote-nvim/providers/utils.lua:180: in function 'is_binary_release_available'
	.../remote-nvim.nvim/lua/remote-nvim/providers/provider.lua:171: in function '_setup_workspace_variables'
	.../remote-nvim.nvim/lua/remote-nvim/providers/provider.lua:872: in function '_launch_neovim'
	.../remote-nvim.nvim/lua/remote-nvim/providers/provider.lua:883: in function <.../remote-nvim.nvim/lua/remote-nvim/providers/provider.lua:882>
	[C]: in function 'xpcall'
	.../remote-nvim.nvim/lua/remote-nvim/providers/provider.lua:759: in function <.../remote-nvim.nvim/lua/remote-nvim/providers/provider.lua:758> ...azy/remote-nvim.nvim/lua/remote-nvim/providers/utils.lua:181: bad argument #1 to 'find' (string expected, got nil)

Screenshot/Screencast(s)

Will add a screencast soon.

System information

  • Your local OS: macOS
  • Local Neovim version: Nightly
  • Remote host OS (if applicable): Debian 10
  • Remote Neovim version (if applicable): N/A
amitds1997 commented

The current scripts are unfortunately just bash scripts that take care of ensuring the Neovim download and installation. I think it would need to be handled somehow though. I'll put some more thoughts on this and let you know once I have a fix in mind.

I have been away for past couple of months and am slowly going through the backlog so this might take a while to get resolved. Thanks for reporting this! Appreciate it!!

hotung1027 commented

I am trying to connect to different machine, but they halt in the install neovim steps.
image

Local:
Ubuntu-20.02
Targets:
JetsonOring(ARM)
Server(Ubuntu)