amoraitis/TodoList

Create a public home, about and contact us page

amoraitis opened this issue · 7 comments

amoraitis commented

Is your feature request related to a problem? Please describe.
We could add our own public pages instead of using the template's defaults.

Describe the solution you'd like
Create a minimal page for each one. Make use of the existing functionality in the HomeController.cs and the existing razor pages under the Views/Home/ directory

Neuron34 commented

Can I work on this issue

  • 👍1
  • ❤️1
amoraitis commented

Can I work on this issue

Of course, use the existing libraries, please.

pirland commented

I'm not sure of the etiquette here, but it looks like I should have posted here first. I just created a pull request with rudimentary versions of these three pages:
#39
Sorry if I stepped on anybodys toes.

  • ❤️1
pirland commented

Also I had the same issue with the projects not loading in Visual Studio. I fixed it by deleting the .vs folder.

amoraitis commented

@pirland Your contributions are welcome, I am going to review them now, unless if there is more work to be done. I can see that the tests aren't updated.

Also, I am not sure why you cannot build the project, I haven't pushed a .vs\ folder here.

Also, please git rebase develop in your branch. Don't merge develop. We would like a clear history of commits.

pirland commented

Thanks. I just noticed the that the tests were failing. I can fix them and recommit. Do you have a preference for testing controllers that return a static view? It was previously testing the ViewData, but I removed that since it was placeholder text.

I'll use rebase from here on out.

pirland commented

Should be good to go now.

  • ❤️1