amphp/beanstalk

Wrong return type in bury promise

mmenozzi opened this issue · 1 comments

mmenozzi commented

Here:

beanstalk/src/BeanstalkClient.php

Line 192 in a5128a0

return $this->send($payload, function (array $response): int {

The return type is int but the promise resolves with a bool value. Should be fixed but it would be a breaking change if someone is relying on a strict type check.

mmenozzi commented

Sorry this is already stated here: #13
Closing.