Add further commands

Question

Add further commands

kelunik opened this issue 7 years ago · 11 comments

kelunik commented 7 years ago

~~Mostly stats commands are missing I think.~~ listTubes() is missing.

kelunik commented 7 years ago

Great!

Answer 1 · 2017-10-03T14:11:58.000Z

hi @kelunik. I can help you with this

Answer 2 · 2017-10-03T15:55:23.000Z

@kelunik here you can find the PR #5

Answer 3 · 2017-10-04T14:12:39.000Z

@kelunik seems can be closed

Answer 4 · 2017-10-04T14:12:59.000Z

Yes, I think there are no more commands left, thanks again!

Answer 5 · 2017-10-04T15:19:04.000Z

@zhikiri I've adjusted your PR, because it needs to return the correct types: cbf8cfa

I'm also reopening this issue, because listTubes() is still missing.

Answer 6 · 2017-10-04T15:27:21.000Z

@kelunik but what about auto conversion for types ? When client will check $stats->job_running > 6 it will be converted from string to int automatically

Answer 7 · 2017-10-04T15:27:53.000Z

and yes, list tubes is missing, your right

Answer 8 · 2017-10-04T15:35:15.000Z

@zhikiri Yes, that mostly works, but it doesn't work with strict_types=1 or assertSame / ===.

Answer 9 · 2017-10-04T15:55:59.000Z

@kelunik so true

Answer 10 · 2017-10-10T13:10:15.000Z

Closing now due to #6 being merged. Thanks!