amphp/parallel-functions

docs/asset file points to non existing file/folder

sci3ma opened this issue · 6 comments

sci3ma commented

v1.0.0
docs/asset file points to .shared/asset which does not exist. .shared/asset seems to be outside of the lib.
It makes failing my deployment flow because my strict policy checks permissions of all files.
Besides that .shared/ folder is empty after installing the library.

sci3ma commented

Thanks @rybakit but unfortunately I'm not sure how it should help me.

kelunik commented

@sci3ma it removes the symlink from the release archives, so it prevents the issue you're seeing.

The directory is empty, because it's a git submodule.

sci3ma commented

Sorry to waste your time but still I'm confused. I have a problem with amphp/parallel-functions, not with amphp/byte-stream.
Correct me if I'm wrong. Shoudl I install amphp/byte-sream to fix issue which is in amphp/parallel-functions?

rybakit commented

@sci3ma Just create a PR with a fix like in amphp/byte-stream@6bbfcb6 and ask @kelunik to merge it and tag a new release :)

  • 👍2
sci3ma commented

@rybakit Couldn't you start with that answer at the beginning? :D thanks for your help. PR created #24