amureki/covidapp

Datetime Format

Closed this issue · 9 comments

hopeman15 commented

The created date format would be nice to have in a more standard way so that it is easier to present the time based on localization:

  • "yyyy-MM-dd'T'HH:mm:ss.SSSZ"
amureki commented

@hopeman15 hey Kyle!
Thanks for the report :)

Could you, please, take a look here (dev API tag):
https://covidapp.herokuapp.com/swagger/

I am testing new API structure, which feels much better (in my opinion). I also changed updated date format there, as you are expecting. ;)

hopeman15 commented

@amureki Noice 👍 this is fun, really taking form 😎 sorry, I meant created not updated 🙈 but on both would be nice too 😉

amureki commented

@hopeman15
So, for example, I imagine response from world endpoint would be like:

{
    "created": "2020-03-09T23:03:09.796172+01:00",
    "confirmed": 113584,
    "deaths": 3996,
    "recovered": 62496,
    "regions_data": [
        {
            "region": "Mainland China",
            "region_slug": "mainland-china",
            "lat": 30.5928,
            "long": 114.3055,
            "confirmed": 80735,
            "deaths": 3120,
            "recovered": 58728,
            "updated": "2020-02-21T06:03:04+01:00"
        },
    ]
}

Is it the format you'd expect?

hopeman15 commented

@hopeman15
So, for example, I imagine response from world endpoint would be like:

{
    "created": "2020-03-10T21:09:09.829Z",
    "confirmed": 113584,
    "deaths": 3996,
    "recovered": 62496,
    "regions_data": [
        {
            "region": "Mainland China",
            "region_slug": "mainland-china",
            "lat": 30.5928,
            "long": 114.3055,
            "confirmed": 80735,
            "deaths": 3120,
            "recovered": 58728,
            "updated": "2020-03-10T21:09:09.829Z"
        },
    ]
}

Is it the format you'd expect?

I was thinking more UTC -> 2020-03-10T21:09:09.829Z then one can let the operating system convert the updated to any given local time, other than that, looking good 👍

hopeman15 commented

@amureki looks like the created date has a few too many milliseconds compared to the updated time format, so trim that bad boy down to two and we're solid 😎
Created: 2020-03-12T06:21:51.524572Z
Updated: 2020-03-11T18:52:03Z

amureki commented

@hopeman15 good catch. :) Fixed and deployed.
Do you have any other suggestions? Would that work for your app if I'd release it as v1? Or you'll be still missing something?

hopeman15 commented

@amureki I would say it's v1 ready 🚀

  • 👍1
amureki commented

Thanks, Kyle, it is there now! ✨