analogdevicesinc/ai8x-training

MaxPool1D stride assertion error/keyword argument naming collision

timber77 opened this issue · 1 comments

Hi

I think there might be a problem in the MaxPool1D class. Especially in the keyword arguments naming going up/down the class hierarchy.

grafik
grafik
grafik

In the Conv1D class if Pooling is not None there is an assertion at the end to check that stride == 1. Since the default value for stride is 3 an explicit setting is needed. Setting stride when using the MaxPool1D seems impossible as the stride keyword in the MaxPool1D gets used as the pooling_stride(line 1262).

Thanks for reporting the issue. The above fix should solve the issue..