Updating for Remix 1.19
Roanmh opened this issue · 6 comments
How much work do you think it would take to make this compatible with remix 1.19?
I hope that it would be as simple as reactivating dependabot but I see that #134 failed CI (though the CI output has expired). Do you know of any development that would be required?
I can take a look and see. All this was done with very little work so I figure it wouldn't take that much time.
Have you seen that SST also have support for Remix now?
https://docs.sst.dev/constructs/RemixSite
Thanks for the pointer. I am adding a Remix UI to an existing project, so iiuc I don't think SST is a good fit.
We currently use the REST API with custom domains. We are hoping to use this plugin to continue using only the REST API until we prioritize the switch to the HTTP API.
@andersquist just wanted to check in since it's been a little bit. Do you have a sense yet for how much effort this would be?
I work with @Roanmh and it might be something we could make a PR for, but if it would be faster for you to do it, that would be fine too 🙂
The status is that I've upgraded to the latest version of Remix and made som minor adjustments that would in theory would make this work.
But the current blocker that is yet to be solved is that there seems to be breaking changes in Remix that causes remix-mount-routes to not work anymore. Or at least not in a way that it used to work. remix-mount-routes is a necessity if you are exposing your site without a custom domain but instead with the stage path that API Gateway enforces you to have.
If you want I could make a PR with what I have and you could take a shot at it?
Sure, I'd be happy to take a look. We usually use a custom domain, except for review envs that are deployed from dev branches, so that'll be an important detail for our use.
You can take a look at it here: #138
Tests are running fine but there are none that cover the mounted path use case as I mentioned so that issue remains.