andreikop/enki

Add Qt5 Webkit as a weak dependency on Fedora

Opened this issue ยท 14 comments

image

Would be nice to have editor working out of the box with all features.

It is controversial topic. Some people prefer "batteries included", and some complain "Why do I have to download and install xxx MB of packages just to edit a little file.
I would agree with you and install webkit out of the box.
@rapgro, what do you think about it?

xxx MB?

# dnf remove python3-qt5-webkit
Dependencies resolved.
======================================================================================
 Package                    Arch           Version              Repository       Size
======================================================================================
Removing:
 python3-qt5-webkit         x86_64         5.10-3.fc28          @fedora         571 k

Transaction Summary
======================================================================================
Remove  1 Package

Freed space: 571 k
Is this ok [y/N]: 

This must be from an old release -- current Enki doesn't use webkit at all but the more modern QtWebEngine. @abitrolly, what release are you running?

Just installed python-qt5.qtwebengine on Linux Mint 19. It is +135 MB. (bindings + binaries + dependencies for binaries).
Let's make it recommended dependency which is installed by default.

This must be from an old release -- current Enki doesn't use webkit at all but the more modern QtWebEngine. @abitrolly, what release are you running?

This issue was forgotten to be closed #410 then? I am running 17.03.0 - https://apps.fedoraproject.org/packages/enki

I just closed #410 -- thanks for pointing that out. It looks like there's not a release with the new non-QWebKit code it in. Perhaps @andreikop can produce one soon. However, code from git master doesn't use webkit.

Fixed with 19.10.0, no?

Yes, If you updated Enki to 19.10.0 the issue is fixed.

I didn't check, but I trust you. )

Hey, @rapgro haven't updated Enki yet (probably).
I hope he'll close the issue when updated.

Sorry for the delay. I'm maintaining the Fedora package in my spare time, so I've to ask you to wait.
Co-maintainers are of course welcome.
See also #465 .

nop, I just keep the issues open and assigned to have clear status and avoid re-opening and re-discussing the topic.

#464 is a blocker for a new package in Fedora.