andrew/first-pr

Upgrade uglify-js to version 3.3.22

andrew opened this issue · 4 comments

Libraries.io has found that there is a newer version of uglify-js that this project depends on.

More info: https://libraries.io/npm/uglify-js/3.3.22

There is a later release for uglify-js v3.3.23. The diff shows some substantial amount of changes, was there a reason why the intention was to update to v3.3.22 or was it because it was the latest release at the time?

@emilioidk it was just the latest release at the time

@andrew I feel a bit embarrassed about asking but how do you normally upgrade the packages? I have been deleting the lock and letting yarn install regenerate it but I am starting to wonder if that is a good idea at all.

If I do that with this repo it comes up with quite a few upgrades, some packages get added and some others get deleted. Should I push all those changes or only those for the packages that are mentioned in the issues?

I usually just run yarn upgrade and commit the resulting changes to the lockfile