andrewabest/Conventional

Dlls from transient / SDKs specification should disallow subdirectories under dotnet/packs

Closed this issue · 5 comments

flakey-bit commented

Wondering if the convention MustNotReferenceDllsFromTransientOrSdkDirectoriesConventionSpecification should include files under dotnet/packs (c:\Program Files\dotnet\packs) in its checking.

In fact, possibly all of

  • dotnet/shared
  • dotnet/sdk

should be verboten too?

flakey-bit commented

@andrewabest If you agree with the proposal, happy to send through a PR.

andrewabest commented

I agree with it in principal - just reading through https://docs.microsoft.com/en-us/dotnet/core/build/distribution-packaging and want to ensure excluding that shared directory is OK.

andrewabest commented

I assume it is OK because framework usage is inferred by other csproj settings, and not via explicit reference.

If this is your understanding too happy to take a PR 👌

flakey-bit commented

I actually don't know for sure - struggling to find documentation confirming one way or the other.

dotnet/designs#50

image

Feel free to close this issue I guess - or leave it open until we know.

andrewabest commented

@flakey-bit I think the best course of action here given the complexity is to wait until this bites someone and they need a convention around it (the classic case for writing conventions) :) Closing until then.