andrewbanchich/solid-state-jekyll-theme

Contributing

Opened this issue · 6 comments

tylerwendell commented

I figured out how to fix some of the path problems. I would love to push the branch and request a review on a pull request but it doesn't appear I can on this repo. I looks like you would prefer that to come through gitlab. But when I click the link I get a 404. Is it private?

andrewbanchich commented

Hi, thanks! It's been a while since I've had the time to work on these themes. I removed the GitLab mirrors, but must have forgotten to update the README.

You should be able to make a PR into this repo! You just need to fork, push to your forked repo, then make a PR into this one.

tylerwendell commented

Maybe you have to open access in some of your settings?

ERROR: Permission to andrewbanchich/solid-state-jekyll-theme.git denied to tylerwendell.
andrewbanchich commented

What produced this error, specifically?

andrewbanchich commented

Others have made PRs: #3

tylerwendell commented

Hmm... weird. Maybe the workflow I am used to isn't allowed. Normally I:
git clone
git checkout -n new_branch
//dev work...
git add .; git commit -m "I did a thing"; git push --set-upstream origin new_branch
And then, on that branch create a pull request to main. It is the workflow I have used for many years now but maybe there is a different expectation common in the open source world?

andrewbanchich commented

Yeah, that's the problem 😁

git push --set-upstream origin new_branch means "push this code to a new branch called new_branch in Andrew's repository", which nobody has permissions to except me. What you want to do is create your own repository (fork) and then push there. Then GitHub will let you open a PR using your repo's new_branch, and it will merge your changes from your repo into mine.