android/camera-samples

BarcodeScanner implements LifecycleObserver, but close is called manually

Opened this issue · 0 comments

Assuming, that the idea of samples is to show best practice of using ML KIT sdk, I would suggest to replace manual call to .close() by lifecycle.addObserver(barcodeScanner).

However if there is a reason not to do so - could you please explain it either in readme or via the comment in the code for clarity.