andy-portmen/external-application-button

Handling double quote in key="value" situation needs to be improved

GunGunGun opened this issue · 0 comments

And I also want to report another wierd bug if I use double quote " in my Arguments it creates a space between my key and value, for example: --http-header-fields= "Referer: undefined", should have been --http-header-fields="Referer: undefined", which is NOT allowed in many cases and this case, MPV will simply ignore --http-header-fields because it was added wrongly, there's NO Referer being sent.

And I also want to say that above glitch can also be considered a bug, because passing D:\mpv\mpv.exe --ytdl --http-header-fields="Referer: https://www.youtube.com/@Retromation/videos" https://www.youtube.com/watch?v=D76FQYWD9aI and passing D:\mpv\mpv.exe --ytdl --http-header-fields= "Referer: https://www.youtube.com/@Retromation/videos" https://www.youtube.com/watch?v=D76FQYWD9aI can result in MPV sending Referer or not, which the former does and the later doesn't. You may want to consider improving quote handling because currently it limits many use cases of External Application Button, because using double quote is mandantory when it comes to using command line arguments.