andy5995/canfigger

Implement support for multiple attributes

Closed this issue · 3 comments

Looking at dnsmasq.conf.example I see it uses multiple attributes (strings following commas). Right now, canfigger only supports one. I was thinking that would probably be a good change to add.

@eteran, For the attribute member of the struct, do you think a c-vector would be a good choice for the data type?

The other option is I could make another node type that would wind up being a linked list to each attribute in the main node, but that seems like overkill.

What do you think?

I decided to just add another linked list for the attributes and avoid adding external dependencies.

@andy5995 c-vector is certainly a reasonable choice anywhere you want a flexible array. However, for your use case, a linked list seems simple enough :-)

Thanks for the feedback @eteran