Division by zero

Question

Division by zero

formigone opened this issue 11 years ago · 3 comments

NlpTools\Similarity\CosineSimilarity::similarity() can divide by zero if $v1_norm or $v2_norm (or both) are equal to zero.

Answer 1 · 2013-10-21T15:21:13.000Z

That is true.

What do you suggest to remedy this? RuntimeException ? InvalidArgumentException? return 0?

It currently returns false and issues a warning.

Answer 2 · 2013-10-25T00:48:04.000Z

It should throw a UnexpectedValueException. I will work on this next.

Answer 3 · 2013-10-25T06:22:49.000Z

UnexpectedValueException php.net
Typically this happens when a function calls another function and expects the return value to be of a certain type or value not including arithmetic or buffer related errors

So I am guessing InvalidArgumentException.