ansible-lint
Closed this issue · 1 comments
hurricanehrndz commented
This role has some ansible-lint issues:
/home/hurricanehrndz/gitrepos/ansible-roles/docker.ubuntu/handlers/main.yml:7
command: systemctl daemon-reload
ANSIBLE0002 Trailing whitespace
/home/hurricanehrndz/gitrepos/ansible-roles/docker.ubuntu/meta/main.yml:25
ANSIBLE0016 Tasks that run when changed should likely be handlers
/home/hurricanehrndz/gitrepos/ansible-roles/docker.ubuntu/tasks/kernel_check_and
Task/Handler: Install Xorg packages for backported kernels (very optional)
ANSIBLE0016 Tasks that run when changed should likely be handlers
/home/hurricanehrndz/gitrepos/ansible-roles/docker.ubuntu/tasks/kernel_check_and
Task/Handler: Reboot instance
ANSIBLE0016 Tasks that run when changed should likely be handlers
/home/hurricanehrndz/gitrepos/ansible-roles/docker.ubuntu/tasks/kernel_check_and
Task/Handler: Wait for instance to come online (10 minute timeout)
ANSIBLE0016 Tasks that run when changed should likely be handlers
/home/hurricanehrndz/gitrepos/ansible-roles/docker.ubuntu/tasks/main.yml:56
Task/Handler: Run dmsetup for Ubuntu 16.04
ANSIBLE0006 curl used in place of get_url or uri module
/home/hurricanehrndz/gitrepos/ansible-roles/docker.ubuntu/tasks/main.yml:68
Task/Handler: Alternative | Add Docker repository key
ANSIBLE0012 Commands should not change things if nothing needs doing
/home/hurricanehrndz/gitrepos/ansible-roles/docker.ubuntu/tasks/main.yml:77
Task/Handler: Return dpkg architecture
ANSIBLE0016 Tasks that run when changed should likely be handlers
/home/hurricanehrndz/gitrepos/ansible-roles/docker.ubuntu/tasks/main.yml:157
Task/Handler: meta flush_handlers
ANSIBLE0011 All tasks should be named
/home/hurricanehrndz/gitrepos/ansible-roles/docker.ubuntu/tasks/main.yml:160
Task/Handler: pause seconds=1 __file__=/home/hurricanehrndz/gitrepos/ansible-roles/docker.ubuntu/tasks/main.yml __line__=160
ANSIBLE0016 Tasks that run when changed should likely be handlers
/home/hurricanehrndz/gitrepos/ansible-roles/docker.ubuntu/tasks/main.yml:160
Task/Handler: pause seconds=1 __file__=/home/hurricanehrndz/gitrepos/ansible-roles/docker.ubuntu/tasks/main.yml __line__=160
ANSIBLE0010 Package installs should not use latest
/home/hurricanehrndz/gitrepos/ansible-roles/docker.ubuntu/tasks/main.yml:165
Task/Handler: Install {{ _python_packages | join(', ') }} packages with apt
I think these need to be addressed.
angstwad commented
I'm don't think any of these linter remarks need to be addressed, except for the whitespace issue and that is not critical.