angstwad/docker.ubuntu

Use apt_key 'url' property instead of 'keyserver'

ainsleybc opened this issue · 1 comments

In the 'Add Docker repository key' task, the keyserver property is used (defaulted to hkp://ha.pool.sks-keyservers.net). This causes problems when behind a proxy server as it's not using the applied proxy config.

Suggested fix:

use the 'url' property with a default of https://download.docker.com/linux/ubuntu/gpg
(recommended best practice - http://docs.ansible.com/ansible/latest/apt_key_module.html)

If ok with the fix then i'll be happy to submit a PR!

update, adding ':80' on to the default keyserver hkp://ha.pool.sks-keyservers.net works behind a proxy (which means we can just set the variable 'apt_key_url' in the playbook :)