angular-redux/ng-redux

subscribe return type in INgRedux

dawidzq opened this issue · 3 comments

dawidzq commented

Hello,

Is there any reason that the subscribe() function returns a Function in index.d.ts rather than type Unsubscribe (defined inside of 'redux')?

AntJanus commented

@dawidzq I'm not a type guru so I can't answer the question but if you feel like you can fix this issue, please open a PR. I'll merge it in and do a release.

dawidzq commented

@AntJanus I created a PR here: #173

Let me know if I did something wrong. This would be my first one. 😄

AntJanus commented

Thanks for the submission! It was merged in.