Apparent defects in Keypress demo
davemerrill opened this issue · 6 comments
- ui-keydown and ui-keyup both insert a newline, though the code appears to be trying to prevent that.
- Pressing alt-Space in the ui-keydown demo shows an alert that immediately dismisses itself in Chrome, and nothing in Firefox.
I'm on Windows 7 Pro, if that matters.
keyup and keydown are not supposed to prevent a newline, and this demo is intended to demonstrate that (and I believe comments on this point too).
As for the alt-space, perhaps a less volatile key-combination should be used?
Dean Sofer
DeanSofer.com
714.900.2254
On Sunday, February 17, 2013 at 5:04 AM, Dave Merrill wrote:
ui-keydown and ui-keyup both insert a newline, though the code appears to be trying to prevent that.
Pressing alt-Space in the ui-keydown demo shows an alert that immediately dismisses itself in Chrome, and nothing in Firefox.
I'm on Windows 7 Pro, if that matters.
—
Reply to this email directly or view it on GitHub (#54).
I guess I misinterpreted the note about preventDefault in ui-keydown. It's not mentioned in the other events, and the same callback, which calls preventDefault, is used for all of them, so it is kind of ambiguous. Might be good to explicitly say that the others can't be cancelled.
Re alt-space, that key combo opens a system menu on Windows, but it does seem to be getting captured in the browser, because that's not happening. I'm not sure what's causing the behavior I see. Do I gather that it works as intended on other platforms?
I think it works okay on other platforms, but it would definitely be good to use a better key combo.
If you want to help us out, open a PR with better notes and changes 😄
Sorry, busy weekend, now busy week... I'd be happy to when I get a chance,
but I can't promise exactly when that is. Lame I know.
Dave Merrill
On Mon, Feb 18, 2013 at 3:54 PM, Dean Sofer notifications@github.comwrote:
@joseym https://github.com/joseym maybe you can look into this one?
—
Reply to this email directly or view it on GitHubhttps://github.com//issues/54#issuecomment-13742637.
Closing. Will have to be dealt with on the official repo.