angular-ui/ui-codemirror

Angular strict dependency injection

maitredede opened this issue · 2 comments

maitredede commented

Hi,

Module is not written for strict dependency injection :

https://docs.angularjs.org/guide/di

Directive declaration should become :
.directive('uiCodemirror', ["$timeout", "uiCodemirrorConfig", uiCodemirrorDirective])

i4got10 commented

👍

bower package has minified version with annotations(via ng-annotate), npm package has not.

  • 👍1
ostruk commented

👍
Took me a while to figure out why it was crashing on production.