`1-service-workers` branch is not working

[lin-brian-l]

I'm attempting to follow along in the Service Workers Hello World course, but even when pulling a fresh copy of the 1-service-workers branch, any script involving the ng command (npm start, npm build, etc) raises the error that the command requires to be run in an Angular project, but a project definition could not be found.. I noticed that the file .angular-cli.json is outdated for later versions of Angular and tried to rename it to angular.json and replace its contents with the angular.json file from the 1-notifications branch, but this raised the error Data path "" should NOT have additional properties(project).. The PWA course was extremely enjoyable up until now; can the repo be updated such that it can be run?

[jhades]

Hello, thank you for filling the issue. I' just fixed the branch 1-service-workers, please update to the latest version everything is working now. Thanks and Kind Regards, Vasco

[lin-brian-l]

Thanks for the quick response @jhades, ng commands work now! I initially ran into some errors with the second lesson because my service workers weren't in the assets array of angular.json, but I haven't ran into any other issues. It may be beneficial to (1) delete the .angular-cli.json file since it seems to be unneeded and (2) add sw-register.js and sw.js into the assets array since the video makes the assumption that they are already added. Thanks again!