angular/dgeni-packages

Esprima dependency should be >1.1.0

mikejpeters opened this issue · 1 comments

It looks like the attachComment option used by jsdocFileReader was added in esprima v1.1.0, so the file reader does not work correctly with esprima v1.0.4.

This seems particularly troublesome in npm v3, which flattens dependencies as long as they don't conflict. My project includes another dependency that specifically wants esprima@1.0.4, which means that dgeni-packages currently also uses that version and fails.

We're also seeing this cause issues with Protractor's setup. Specifically, something in the depths of bower's dependencies uses esprima at 1.0.4.