writeFilesProcessor never exits
Closed this issue · 22 comments
I was experiencing this with my own app, so I downloaded the latest copy of this too: https://github.com/pvadam/dgeni-example
When running "gulp", it just never exits the process after getting to writeFilesProcessor.
Hmm, I guess it is related to my rebuild in TypeScript? With what versions of dgeni does it happen?
This was with the latest versions. You want me to try to roll back a few versions?
I just pulled down my original dgeni-example repo updated the dgeni and dgeni-packages versions and ran it with gulp.
The writeFilesProcessor did not hang.
I have pushed to that repo the new package.json. Perhaps you could try with that?
I will try that.
Maybe it has something to do with Typescript?
Yes, that worked fine.
I just updated to the latest dgeni and dgeni packages for that branch and the problem stopped.. Guess there was a bug fixed in there somewhere.
So.. here's the setup.
grab the code from here: https://github.com/pvadam/dgeni-example/tree/typescript-example
then update to the latest dgeni and dgeni-packages.
Then the writeFilesProcessor never exits
I will take a look tomorrow!
I don't want to pester (but I will).
Did you get a chance to look at this?
Fair enough - today is not what was going to be tomorrow. I'll look in the next hour...
Thanks so much. I really appreciate it
I just did the following (node version 6.9.5, OS/X Sierra)
git clone https://github.com/pvadam/dgeni-example
cd dgeni-example/
git checkout origin/typescript-example
git checkout -b typescript-example
npm install
npm install dgeni@latest dgeni-packages@latest
gulpAnd I get a massive long output (as expected since it is set to log "silly")
But it does not hang on the writeFilesProcessor....
The last few lines of the log look like:
info: running processor: writeFilesProcessor
silly: writing file /Users/pete/dev/dgeni/temp/dgeni-example/build/partials/modules/src/app/index.html
silly: writing file /Users/pete/dev/dgeni/temp/dgeni-example/build/partials/modules/src/app/helloDgeni/index.html
debug: Document "src/app/MyApp.greet, member" has no outputPath.
silly: writing file /Users/pete/dev/dgeni/temp/dgeni-example/build/partials/modules/Users/pete/dev/dgeni/temp/dgeni-example/src/logger/index.html
silly: writing file /Users/pete/dev/dgeni/temp/dgeni-example/build/partials/modules/Users/pete/dev/dgeni/temp/dgeni-example/src/logger/Logger/index.html
debug: Document "/Users/pete/dev/dgeni/temp/dgeni-example/src/logger/Logger.log, member" has no outputPath.
debug: written file /Users/pete/dev/dgeni/temp/dgeni-example/build/partials/modules/src/app/index.html
debug: written file /Users/pete/dev/dgeni/temp/dgeni-example/build/partials/modules/src/app/helloDgeni/index.html
debug: written file /Users/pete/dev/dgeni/temp/dgeni-example/build/partials/modules/Users/pete/dev/dgeni/temp/dgeni-example/src/logger/index.html
debug: written file /Users/pete/dev/dgeni/temp/dgeni-example/build/partials/modules/Users/pete/dev/dgeni/temp/dgeni-example/src/logger/Logger/index.html
info: running processor: checkAnchorLinksProcessor
silly: checking file hrefs=[], names=[], path=/src/app, outputPath=partials/modules/src/app/index.html
silly: checking file hrefs=[], names=[], path=/src/app/helloDgeni, outputPath=partials/modules//src/app/helloDgeni/index.html
silly: checking file hrefs=[], names=[], path=/Users/pete/dev/dgeni/temp/dgeni-example/src/logger, outputPath=partials/modules//Users/pete/dev/dgeni/temp/dgeni-example/src/logger/index.html
silly: checking file hrefs=[], names=[], path=/Users/pete/dev/dgeni/temp/dgeni-example/src/logger/Logger, outputPath=partials/modules///Users/pete/dev/dgeni/temp/dgeni-example/src/logger/Logger/index.html
I'm on windows and I'm running Node 6, but an older version.. lemme update and try again (because your commands do lockup on writeFilesProcessor for me)
Upgraded to node 6.10.0 and it still locks up on writeFilesProcessor :(
Anyone else who can test this on windows?
I'm on Windows 10 in case that matters
Last few lines
info: running processor: unescapeCommentsProcessor
info: running processor: inlineTagProcessor
info: running processor: writeFilesProcessor
silly: writing file C:/dev/delete/dgeni-example/build/partials/modules/src/app/index.html
silly: writing file C:/dev/delete/dgeni-example/build/partials/modules/src/app/helloDgeni/index.html
debug: Document "src/app/MyApp.greet, member" has no outputPath.
silly: writing file C:/dev/delete/dgeni-example/build/partials/modules/C:/dev/delete/dgeni-example/src/logger/index.html
silly: writing file C:/dev/delete/dgeni-example/build/partials/modules/C:/dev/delete/dgeni-example/src/logger/Logger/index.html
debug: Document "C:/dev/delete/dgeni-example/src/logger/Logger.log, member" has no outputPath.
debug: written file C:/dev/delete/dgeni-example/build/partials/modules/src/app/index.html
debug: written file C:/dev/delete/dgeni-example/build/partials/modules/src/app/helloDgeni/index.html
I tried this on Windows 10 (node v6.9.5) and it does hang with the same output as @tommck (except the last two lines are swapped 😕 ).
OK. I better dig my windows machine out from a cupboard...
OK, so we had a similar problem on OS/X but the mkdirp was not crashing. Instead we were getting weird output folder structures.
The problem was that TypeScript provides absolute paths to files that are imported rather than added to the list of program modules.
So the logger.ts file was being reported as c:\some\absolute\path\logger.ts, which caused its id to be similar and then its outputPath to be something like: c:\build\partials\c:\some\absolute\path\logger.html
The fix is here angular/dgeni-packages#213
@gkalpak has confirmed that this resolves the problem on his Windows copy.
I need to do some other integration testing before I release a new version.
I'm sooooo glad! Thought I was crazy there for a while!
Thank you to so much for the help
Fixed in 0.17.1